Skip to content

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Sep 23, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211407036705136?focus=true

Description

Adds JS->native communication so we know which step of the automated Takeout flow we're on at any given time. The primary use case for this will be in a later PR around cancellation so there's not much to see in terms of changes in this PR.

Steps to test this PR

Logcat filter: Bookmark-import:

Test success, steps communicated

  • Fresh install internal build type
  • Visit Autofill Dev Settings and choose to Launch Bookmarks Import Flow
  • You'll see the sign in page; verify in logs you see latest step is: login-first
  • Sign and let the automation carry on. Verify you see a bunch of steps being notified as it goes.
  • Allow it to complete, and verify in the last few steps you see download-detected and completed-successful

Test cancellation

  • choose to Launch Bookmarks Import Flow again
  • while it is showing the in-progress view, tap the X and confirm you want to cancel
  • verify you see in the logs cancelled at stage: (where the value will vary based on when you cancelled it)

Test error encountered in step processing

  • Apply patch which will simulate an error step
  • Tap on Launch Bookmarks Import Flow and wait for the simulated error to happen
  • Verify you see the error screen
  • Verify in the logs you see Import failed with reason: WebAutomationError(step=bookmark-modal-expectation)

Copy link
Member Author

CDRussell commented Sep 23, 2025

@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow branch 2 times, most recently from a039a47 to 3f8950c Compare September 23, 2025 13:25
@CDRussell CDRussell changed the base branch from feature/craig/streamline_import_add_bookmarks_webflow to graphite-base/6837 September 24, 2025 09:18
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from afcb27d to 51594c0 Compare September 24, 2025 09:18
@CDRussell CDRussell changed the base branch from graphite-base/6837 to feature/craig/streamline_import_bookmarks_webview_ui September 24, 2025 09:19
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch 3 times, most recently from 1875079 to bf83ce2 Compare September 24, 2025 10:44
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 2 times, most recently from 1713a4f to cb2b5cb Compare September 24, 2025 10:49
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from bf83ce2 to 8a51bdd Compare September 24, 2025 10:49
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from cb2b5cb to bde236b Compare September 24, 2025 10:54
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch 2 times, most recently from a0d7aa3 to e9faa31 Compare September 24, 2025 10:59
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 2 times, most recently from dfbcd8e to 7f7ff4b Compare September 24, 2025 11:18
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch 2 times, most recently from 49f326c to b0b82a3 Compare September 24, 2025 13:44
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 7f7ff4b to 2e9a36c Compare September 24, 2025 13:45
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from b0b82a3 to ee4b18d Compare September 24, 2025 13:45
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 2e9a36c to 7ac6dca Compare September 24, 2025 14:18
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from ee4b18d to 7558977 Compare September 24, 2025 14:18
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 7ac6dca to 49ab43d Compare September 25, 2025 13:35
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from 7558977 to 9a236d1 Compare September 25, 2025 13:35
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from de3309e to 700a40b Compare October 7, 2025 11:50
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch 2 times, most recently from 2419f4d to 2c92bc8 Compare October 7, 2025 11:51
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 700a40b to c0e55d8 Compare October 7, 2025 11:51
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from 2c92bc8 to dbede8d Compare October 7, 2025 11:52
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from c0e55d8 to 36102cf Compare October 7, 2025 11:52
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from dbede8d to 4ece959 Compare October 7, 2025 11:54
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 36102cf to b21df47 Compare October 7, 2025 11:54
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from 4ece959 to 08a816c Compare October 7, 2025 12:29
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch 2 times, most recently from f942c31 to d2f84e9 Compare October 7, 2025 12:30
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from 08a816c to 8032ddd Compare October 7, 2025 12:30
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from d2f84e9 to 2e82169 Compare October 7, 2025 16:16
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch 3 times, most recently from 6d1675a to a861977 Compare October 8, 2025 11:15
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 2e82169 to f18b377 Compare October 8, 2025 11:15
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from a861977 to 5357163 Compare October 8, 2025 12:50
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from f18b377 to 204a3c4 Compare October 8, 2025 12:50
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from 5357163 to 72cb853 Compare October 8, 2025 15:56
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 204a3c4 to 94ccf12 Compare October 8, 2025 15:56
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_bookmarks_webview_ui branch from 94ccf12 to 889c892 Compare October 8, 2025 23:39
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch 3 times, most recently from 193760e to 482ba59 Compare October 9, 2025 09:24
@CDRussell CDRussell force-pushed the feature/craig/streamline_import_add_bookmarks_webflow_messaging branch from 482ba59 to ea5115e Compare October 9, 2025 09:59
@CDRussell CDRussell marked this pull request as ready for review October 9, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants