-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add web message listener for js call from bookmark import #6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CDRussell
wants to merge
1
commit into
feature/craig/streamline_import_bookmarks_webview_ui
Choose a base branch
from
feature/craig/streamline_import_add_bookmarks_webflow_messaging
base: feature/craig/streamline_import_bookmarks_webview_ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+718
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 23, 2025
a039a47
to
3f8950c
Compare
3f8950c
to
a14e381
Compare
afcb27d
to
51594c0
Compare
1875079
to
bf83ce2
Compare
1713a4f
to
cb2b5cb
Compare
bf83ce2
to
8a51bdd
Compare
cb2b5cb
to
bde236b
Compare
a0d7aa3
to
e9faa31
Compare
dfbcd8e
to
7f7ff4b
Compare
49f326c
to
b0b82a3
Compare
7f7ff4b
to
2e9a36c
Compare
b0b82a3
to
ee4b18d
Compare
2e9a36c
to
7ac6dca
Compare
ee4b18d
to
7558977
Compare
7ac6dca
to
49ab43d
Compare
7558977
to
9a236d1
Compare
de3309e
to
700a40b
Compare
2419f4d
to
2c92bc8
Compare
700a40b
to
c0e55d8
Compare
2c92bc8
to
dbede8d
Compare
c0e55d8
to
36102cf
Compare
dbede8d
to
4ece959
Compare
36102cf
to
b21df47
Compare
4ece959
to
08a816c
Compare
f942c31
to
d2f84e9
Compare
08a816c
to
8032ddd
Compare
d2f84e9
to
2e82169
Compare
6d1675a
to
a861977
Compare
2e82169
to
f18b377
Compare
a861977
to
5357163
Compare
f18b377
to
204a3c4
Compare
5357163
to
72cb853
Compare
204a3c4
to
94ccf12
Compare
94ccf12
to
889c892
Compare
193760e
to
482ba59
Compare
482ba59
to
ea5115e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211407036705136?focus=true
Description
Adds JS->native communication so we know which step of the automated Takeout flow we're on at any given time. The primary use case for this will be in a later PR around cancellation so there's not much to see in terms of changes in this PR.
Steps to test this PR
Logcat filter:
Bookmark-import:
Test success, steps communicated
internal
build typeAutofill Dev Settings
and choose toLaunch Bookmarks Import Flow
latest step is: login-first
download-detected
andcompleted-successful
Test cancellation
Launch Bookmarks Import Flow
againcancelled at stage:
(where the value will vary based on when you cancelled it)Test error encountered in step processing
Launch Bookmarks Import Flow
and wait for the simulated error to happenImport failed with reason: WebAutomationError(step=bookmark-modal-expectation)